Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): return response from loginWith #541

Merged
merged 9 commits into from
Mar 3, 2020
Merged

feat(core): return response from loginWith #541

merged 9 commits into from
Mar 3, 2020

Conversation

JoaoPedroAS51
Copy link
Collaborator

@JoaoPedroAS51 JoaoPedroAS51 commented Feb 27, 2020 •
edited
Loading

Fix issue #144

This closes #144, closes #411 and closes #249

@JoaoPedroAS51 JoaoPedroAS51 requested a review from pi0 February 27, 2020 02:28
@codecov
Copy link

codecov bot commented Feb 27, 2020 •
edited
Loading

Codecov Report

Merging #541 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #541   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344920c...2312127. Read the comment docs.

@vincent-kean
Copy link

Waiting for this

pi0
pi0 reviewed Mar 2, 2020
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR ❤️

docs/schemes/local.md Outdated Show resolved Hide resolved
lib/core/auth.js Outdated Show resolved Hide resolved
@JoaoPedroAS51 JoaoPedroAS51 requested a review from pi0 March 2, 2020 20:46
@pi0 pi0 changed the title Fix loginWith promise result feat(core): return response from loginWith Mar 3, 2020
@pi0 pi0 merged commit 7e4f1ed into dev Mar 3, 2020
@pi0 pi0 deleted the fix/loginwith-response branch March 3, 2020 14:37
@pi0
Copy link
Member

pi0 commented Mar 3, 2020

Awesome @JoaoPedroAS51 thanks!

@pi0
Copy link
Member

pi0 commented Mar 15, 2020

Released with v4.9.0.

This was referenced Apr 7, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@JoaoPedroAS51 @vincent-kean @pi0